Skip to content

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented Jan 22, 2026

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This focuses on EC2 clients in the pkg/asset and dependent pkg(s). To check if any AWS SDK v1, we can run:

$ grep -InHr '"github.com/aws/aws-sdk-go/service/ec2"' "pkg" --color=always --exclude-dir={vendor}
pkg/asset/installconfig/aws/instancetypes.go:9:	"github.com/aws/aws-sdk-go/service/ec2"

Notes: instancetypes.go file will be migrated to AWS SDK v2 in #10238 as part of dual-stack work. Depending on the merge order, one must go mod tidy to remove unused AWS SDK v1 EC2 dependencies.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 22, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2026

@tthvo: This pull request references CORS-4055 which is a valid jira issue.

Details

In response to this:

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This focuses on EC2 clients in the pkg/asset and dependent pkg(s). To check if any AWS SDK v1, we can run:

$ grep -InHr '"github.com/aws/aws-sdk-go/service/ec2"' "pkg" --color=always --exclude-dir={vendor}
pkg/asset/installconfig/aws/instancetypes.go:9:	"github.com/aws/aws-sdk-go/service/ec2"

Notes: instancetypes.go file will be migrated to AWS SDK v2 in #10238 as part of dual-stack work. Depending on the merge order, one must go mod tidy to remove unused AWS SDK v1 EC2 dependencies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member Author

tthvo commented Jan 22, 2026

/cc @barbacbd @yunjiang29

@openshift-ci openshift-ci bot requested review from barbacbd and yunjiang29 January 22, 2026 01:46
@tthvo
Copy link
Member Author

tthvo commented Jan 22, 2026

/test e2e-aws-ovn-public-ipv4-pool e2e-aws-ovn-public-subnets e2e-aws-ovn-heterogeneous

@tthvo
Copy link
Member Author

tthvo commented Jan 22, 2026

/label platform/aws

@yunjiang29
Copy link
Contributor

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-fips-mini-perm-f14

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@yunjiang29: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-fips-mini-perm-f14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/788c71a0-f844-11f0-91e3-6f9960d4134a-0

@yunjiang29
Copy link
Contributor

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-byo-subnet-ovn-mini-perm-f14

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@yunjiang29: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-byo-subnet-ovn-mini-perm-f14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/917c9190-f844-11f0-92e7-f4ed54b9f812-0

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2026
@barbacbd
Copy link
Contributor

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2026
@tthvo
Copy link
Member Author

tthvo commented Jan 27, 2026

/test e2e-aws-ovn-public-ipv4-pool e2e-aws-ovn-public-subnets

The commit is an incremental step to migrate AWS API calls to AWS SDK
v2. This focuses on EC2 clients in the pkg/asset and dependent pkg(s).
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2026

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-byo-subnet-ovn-mini-perm-f14

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-byo-subnet-ovn-mini-perm-f14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/56e29a70-fbe1-11f0-8469-3c3ba4209811-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@tthvo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-heterogeneous 6fef118 link false /test e2e-aws-ovn-heterogeneous

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yunjiang29
Copy link
Contributor

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-fips-mini-perm-f14

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@yunjiang29: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-localzone-fips-mini-perm-f14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5833d3f0-fc20-11f0-87c9-17f20ec54e08-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. platform/aws

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants